[Proposal] Correctly encode/decode multi level type hierarchy with multiple labels. #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress. However, I would like to share the proposal first, and complete it (or postpone it) depending on the feedback.
This PR is a proposal to fix the two issues above (there are more relevant issues, so it has a high demand). The work mainly benefits the
toJsonpart becausefromJsonworks correctly.The idea is to fetch through the type hierarchy to find the non-PolymorphicJsonAdapter instance and record the label information throughout the search. Lastly, it writes the recorded labels of the ancestor types before using the actual JsonAdapter to complete writing the JSON.